Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector,test: zero out expectations #8985

Closed
wants to merge 2 commits into from
Closed

inspector,test: zero out expectations #8985

wants to merge 2 commits into from

Conversation

joaocgreis
Copy link
Member

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Inspector (test)

Description of change

VS2013 was not running in CI for v6 when #8832 landed. When compiling with VS2013 and running on Windows 2008, cctest.exe hangs consuming 100% CPU. This happens because Visual Studio 2013 does not zero out the expectations structure when allocating.

@nodejs/release this only needs to land if #7989 is not approved before the next v6 release.

CI: https://ci.nodejs.org/view/All/job/node-test-commit/5512/

cc @nodejs/v8-inspector

@joaocgreis
inspector,test: zero out expectations
90176a8 
Visual Studio 2013 does not zero out the structure when allocating.
@joaocgreis joaocgreis added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol labels Oct 8, 2016
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Oct 8, 2016
bnoordhuis
bnoordhuis approved these changes Oct 10, 2016
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But can you add an explaining comment?

@joaocgreis
Copy link
Member Author

Thanks, updated.

@eugeneo
Copy link
Contributor

eugeneo commented Oct 10, 2016

LGTM. Thanks!

@joaocgreis
Copy link
Member Author

#7989 resolved, no need to land this.

Still, thanks for the reviews!

@joaocgreis joaocgreis closed this Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joaocgreis @eugeneo @bnoordhuis @nodejs-github-bot